Enable IJSObjectReference to handle null/undefined values #62657
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @@rolandVi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
oroztocil
reviewed
Jul 10, 2025
| @@ -87,4 +87,17 @@ public void Write_WritesValidJson() | |||
| // Assert | |||
| Assert.Equal($"{{\"__jsObjectId\":{jsObjectRef.Id}}}", json); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void Read_ReturnsNull_WhenJSObjectIdIsMinusOne() | |||
There was a problem hiding this comment.
This is a rather white-box kind of test. Consider adding an E2E test.
There was a problem hiding this comment.
@oroztocil point @rolandVi to the JS E2E tests location, since you were modifying them recently.
|
Please check that you get an expected result when you do
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable IJSObjectReference to handle null/undefined values
Problem
Currently, calling
DotNet.createJSObjectReference(null)orDotNet.createJSObjectReference(undefined)throws an error: This forces developers to write workaround code when JavaScript functions might return null/undefined values.Solution
Modified
createJSObjectReferenceto handle null/undefined values by returning a special sentinel object with__jsObjectId: -1instead of throwing an error. The .NET side JSON converter recognizes this sentinel value and returnsnullfor theIJSObjectReference?.Changes
createJSObjectReference()now accepts null/undefined and returns{__jsObjectId: -1}JSObjectReferenceJsonConverterrecognizes the-1sentinel and returnsnulldisposeJSObjectReference()to safely handle null references (skip disposal for id-1)Benefits
Fixes #52070